Change order of arguments for consistency

pull/3746/head
Junegunn Choi 2 months ago
parent 2876205a0a
commit 0ef31b55d5
No known key found for this signature in database
GPG Key ID: 254BC280FEF9C627

@ -130,7 +130,7 @@ func Run(opts *Options, version string, revision string) {
if !streamingFilter {
reader = NewReader(func(data []byte) bool {
return chunkList.Push(data)
}, executor, eventBox, opts.ReadZero, opts.Filter == nil)
}, eventBox, executor, opts.ReadZero, opts.Filter == nil)
go reader.ReadSource(opts.WalkerRoot, opts.WalkerOpts, opts.WalkerSkip)
}
@ -181,7 +181,7 @@ func Run(opts *Options, version string, revision string) {
mutex.Unlock()
}
return false
}, executor, eventBox, opts.ReadZero, false)
}, eventBox, executor, opts.ReadZero, false)
reader.ReadSource(opts.WalkerRoot, opts.WalkerOpts, opts.WalkerSkip)
} else {
eventBox.Unwatch(EvtReadNew)

@ -31,7 +31,7 @@ type Reader struct {
}
// NewReader returns new Reader object
func NewReader(pusher func([]byte) bool, executor *util.Executor, eventBox *util.EventBox, delimNil bool, wait bool) *Reader {
func NewReader(pusher func([]byte) bool, eventBox *util.EventBox, executor *util.Executor, delimNil bool, wait bool) *Reader {
return &Reader{pusher, executor, eventBox, delimNil, int32(EvtReady), make(chan bool, 1), sync.Mutex{}, nil, nil, false, wait}
}

@ -13,7 +13,7 @@ func TestReadFromCommand(t *testing.T) {
exec := util.NewExecutor("")
reader := NewReader(
func(s []byte) bool { strs = append(strs, string(s)); return true },
exec, eb, false, true)
eb, exec, false, true)
reader.startEventPoller()

Loading…
Cancel
Save