ui-repolist.c: do not return random/stale data from read_agefile

When git/date.c:parse_date() cannot parse its input it returns -1. But
read_agefile() checks if the result is different from zero, essentialy
returning random data from the date buffer when parsing fails. This
patch fixes the issue by verifying that the result from parse_date()
is positive.

Noticed-by: Julius Plenz <plenz@cis.fu-berlin.de>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
lh/pretty-blob-view
Lars Hjemli 13 years ago
parent 9afc883297
commit c8ea73caab

@ -20,7 +20,7 @@ time_t read_agefile(char *path)
if (readfile(path, &buf, &size))
return -1;
if (parse_date(buf, buf2, sizeof(buf2)))
if (parse_date(buf, buf2, sizeof(buf2)) > 0)
result = strtoul(buf2, NULL, 10);
else
result = 0;

Loading…
Cancel
Save