Drop unused columns from asciicasts table

openid
Marcin Kulik 10 years ago
parent 24bad5e628
commit 81c8340bc1

@ -51,7 +51,7 @@ class Asciicast < ActiveRecord::Base
end
def user
super || self.user = User.new(nickname: username).tap { |u| u.dummy = true }
super || self.user = User.new(nickname: 'anonymous').tap { |u| u.dummy = true }
end
def stdout

@ -0,0 +1,6 @@
class RemoveUsernameAndApiTokenFromAsciicasts < ActiveRecord::Migration
def change
remove_column :asciicasts, :username
remove_column :asciicasts, :api_token
end
end

@ -11,7 +11,7 @@
#
# It's strongly recommended that you check this file into your version control system.
ActiveRecord::Schema.define(version: 20140211152727) do
ActiveRecord::Schema.define(version: 20140212193024) do
# These are extensions that must be enabled in order to support this database
enable_extension "plpgsql"
@ -42,10 +42,8 @@ ActiveRecord::Schema.define(version: 20140211152727) do
t.string "stdin_timing"
t.string "stdout_data"
t.string "stdout_timing"
t.string "api_token"
t.text "description"
t.boolean "featured", default: false
t.string "username"
t.integer "likes_count", default: 0, null: false
t.text "snapshot"
t.integer "comments_count", default: 0, null: false
@ -55,7 +53,6 @@ ActiveRecord::Schema.define(version: 20140211152727) do
t.string "user_agent"
end
add_index "asciicasts", ["api_token"], name: "index_asciicasts_on_api_token", using: :btree
add_index "asciicasts", ["created_at"], name: "index_asciicasts_on_created_at", using: :btree
add_index "asciicasts", ["featured"], name: "index_asciicasts_on_featured", using: :btree
add_index "asciicasts", ["likes_count"], name: "index_asciicasts_on_likes_count", using: :btree

@ -1,15 +0,0 @@
namespace :asciinema do
desc "Assign anonymous asciicasts to dummy users"
task assign_asciicasts_to_users: :environment do
Asciicast.transaction do |tx|
Asciicast.where('api_token IS NOT NULL').each do |asciicast|
user = User.for_api_token(asciicast.api_token, asciicast.username)
puts "assigning asciicast ##{asciicast.id} to user ##{user.id} (#{user.nickname})"
asciicast.user = user
asciicast.username = nil
asciicast.api_token = nil
asciicast.save!
end
end
end
end

@ -57,10 +57,6 @@ describe Asciicast do
describe '#user' do
subject { asciicast.user }
before do
asciicast.username = 'hugo'
end
context "when it has user assigned" do
let(:user) { User.new }
@ -76,8 +72,8 @@ describe Asciicast do
expect(asciicast.user).to be_dummy
end
it 'is a user with nickname set to username' do
expect(asciicast.user.nickname).to eq('hugo')
it 'is a user with "anonymous" as nickname' do
expect(asciicast.user.nickname).to eq('anonymous')
end
end
end

Loading…
Cancel
Save